Fix #19294, Ruby NetHttpRequest improvements #20101
Open
+40
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwager
commented
Jul 21, 2025
Comment on lines
+20
to
+24
| * | ||
| * # connection re-use | ||
| * Net::HTTP.start("http://example.com") do |http| | ||
| * http.get("/") | ||
| * end |
There was a problem hiding this comment.
Note that technically Net::HTTP.new does not open/reuse connections/sessions: https://docs.ruby-lang.org/en/master/Net/HTTP.html#method-c-new
Comment on lines
+31
to
+33
| http = Net::HTTP.new("https://example.com") | ||
| root_get = Net::HTTP::Get.new("/") | ||
| http.request(root_get) |
There was a problem hiding this comment.
This case was already detected without the above code modifications, but I wanted to make sure that request objects are also detected correctly.
hvitved
requested changes
Aug 4, 2025
| @@ -12,15 +12,22 @@ private import codeql.ruby.DataFlow | |||
| /** | |||
| * A `Net::HTTP` call which initiates an HTTP request. | |||
| * ```ruby | |||
| * # one-off request | |||
There was a problem hiding this comment.
This file needs to be auto-formatted, using codeql query format --in-place NetHttp.qll.
| @@ -30,20 +37,27 @@ class NetHttpRequest extends Http::Client::Request::Range instanceof DataFlow::C | |||
| | | |||
| // Net::HTTP.get(...) | |||
| method in ["get", "get_response"] and | |||
| requestNode = API::getTopLevelMember("Net").getMember("HTTP").getReturn(method) and | |||
| connectionNode = API::getTopLevelMember("Net").getMember("HTTP") and | |||
| requestNode = connectionNode.getReturn(method) and | |||
There was a problem hiding this comment.
You can move requestNode = connectionNode.getReturn(method) up after line 36, and then remove the three duplicated lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 3 improvements to the
NetHttpRequestclass:connectionNodelike other Ruby HTTP clients (see Ruby NetHttpRequest improvements #19294)requestNodeandconnectionNodepublic so subclasses can use them (see Ruby NetHttpRequest improvements #19294)Net::HTTP.start- this is a common way to make HTTP requests in Ruby